-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39745/32599

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39745/32599/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39745/32599/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39745/32600

• This PR adds an extra 36KB to repository

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FWCore/Concurrency (core)
• FWCore/Framework (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

please test

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e377be/28307/summary.html
COMMIT: c845db0
CMSSW: CMSSW_12_6_X_2022-10-17-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39745/28307/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @abrinke1 Fix trigger matching issues in L1Trigger DQMOffline #39691
• @Dr15Jones Added transformAsync ability to modules #39557
• @ChrisMisan PPS automatic workflows for timing calibration #39652
• @mmusich add edm::one::SharedResources to DQM/SiStripMonitorClient plugins #39723
• @srimanob Update Phase-2 Tracker and HGCAL HLT config files #39733
• @bsunanda Phase2-hgx327 Modify the scripts needed to produce samples for muon tomography for HGCal #39683
• @finnlabe B2G HLT DQM threshold and binning changes #39684

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e377be/28307/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e377be/28307/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestFWCoreConcurrencyDriver had ERRORS
---> test test_TreeAndTkMapProducer had ERRORS

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e377be/2500.601_mc126X+TTBarMINIAOD12.6+NANO_mc12.6+HRV_NANO_mc

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3391158
• DQMHistoTests: Total failures: 88
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3391048
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.468 KiB( 47 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -0.078 KiB HLT/B2G
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

please test

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39745/32613

• This PR adds an extra 44KB to repository

Pull request #39745 was updated. @makortel, @smuzaffar, @Dr15Jones can you please check and sign again.

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e377be/28336/summary.html
COMMIT: a238996
CMSSW: CMSSW_12_6_X_2022-10-18-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39745/28336/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3391158
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3391130
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

+1

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

+1